Largeobject Access Controls (r2460)
in [PgSql]
|
Prev: explain output infelicity in psql
Next: Winflex
From: Bruce Momjian on 12 Dec 2009 20:24 KaiGai Kohei wrote: > > What happens when > > there is no entry in pg_largeobject_metadata for a specific row? > > In this case, these rows become orphan. > So, I think we need to create an empty large object with same LOID on > pg_migrator. It makes an entry on pg_largeobject_metadata without > writing anything to the pg_largeobject. > I guess rest of migrations are not difference. Correct? Agreed. I have modified pg_migrator with the attached patch which creates a script that adds default permissions for all large object tables. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
From: Takahiro Itagaki on 13 Dec 2009 19:40 KaiGai Kohei <kaigai(a)kaigai.gr.jp> wrote: > We don't have any reason why still CASE ... WHEN and subquery for the given > LOID. Right? Ah, I see. I used your suggestion. I applied the bug fixes. Our tools and contrib modules will always use pg_largeobject_metadata instead of pg_largeobject to enumerate large objects. I removed "GRANT SELECT (loid) ON pg_largeobject TO PUBLIC" from initdb because users must use pg_largeobject_metadata.oid when they want to check OIDs of large objects; If not, they could misjudge the existence of objects. This is an unavoidable incompatibility unless we always have corresponding tuples in pg_largeobject even for zero-length large objects. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 16 Dec 2009 17:25 On Thu, Dec 10, 2009 at 10:41 PM, Takahiro Itagaki <itagaki.takahiro(a)oss.ntt.co.jp> wrote: > > KaiGai Kohei <kaigai(a)ak.jp.nec.com> wrote: > >> What's your opinion about: >> long desc: When turned on, privilege checks on large objects perform with >> backward compatibility as 8.4.x or earlier releases. > > I updated the description as your suggest. > > Applied with minor editorialization, > mainly around tab-completion support in psql. The documentation in this patch needs work. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: KaiGai Kohei on 16 Dec 2009 18:18 (2009/12/17 7:25), Robert Haas wrote: > On Thu, Dec 10, 2009 at 10:41 PM, Takahiro Itagaki > <itagaki.takahiro(a)oss.ntt.co.jp> wrote: >> >> KaiGai Kohei<kaigai(a)ak.jp.nec.com> wrote: >> >>> What's your opinion about: >>> long desc: When turned on, privilege checks on large objects perform with >>> backward compatibility as 8.4.x or earlier releases. >> >> I updated the description as your suggest. >> >> Applied with minor editorialization, >> mainly around tab-completion support in psql. > > The documentation in this patch needs work. Are you talking about English quality? or Am I missing something to be documented? -- OSS Platform Development Division, NEC KaiGai Kohei <kaigai(a)ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 16 Dec 2009 23:20
2009/12/16 KaiGai Kohei <kaigai(a)ak.jp.nec.com>: > (2009/12/17 7:25), Robert Haas wrote: >> On Thu, Dec 10, 2009 at 10:41 PM, Takahiro Itagaki >> <itagaki.takahiro(a)oss.ntt.co.jp> wrote: >>> >>> KaiGai Kohei<kaigai(a)ak.jp.nec.com> wrote: >>> >>>> What's your opinion about: >>>> long desc: When turned on, privilege checks on large objects perform with >>>> backward compatibility as 8.4.x or earlier releases. >>> >>> I updated the description as your suggest. >>> >>> Applied with minor editorialization, >>> mainly around tab-completion support in psql. >> >> The documentation in this patch needs work. > > Are you talking about English quality? or Am I missing something to be > documented? Mostly English quality, but there are some other issues too. Proposed patch attached. ....Robert |