Prev: [tip:x86/uv] x86, UV: BAU structure rearranging
Next: [PATCH v2] x86: Unify dumpstack.h and stacktrace.h
From: Greg KH on 8 Jun 2010 17:20
On Mon, Jun 07, 2010 at 11:49:34AM -0700, Joe Perches wrote:
> Some drivers/staging directories use a TODO file with email entries.
> Make the same entries in the normal MAINTAINERS file.

No, please don't do this. I don't want to clutter up the MAINTAINERS
file with staging stuff. The get_maintainer.pl script handles staging
patches just fine today without this being needed at all.

I also found it a bit odd you didn't send these to the stable subsystem
maintainer, why?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 8 Jun 2010 17:30
On Tue, 2010-06-08 at 14:12 -0700, Greg KH wrote:
> On Mon, Jun 07, 2010 at 11:49:34AM -0700, Joe Perches wrote:
> > Some drivers/staging directories use a TODO file with email entries.
> > Make the same entries in the normal MAINTAINERS file.
>
> No, please don't do this. I don't want to clutter up the MAINTAINERS
> file with staging stuff.

It's not clutter when it helps get patches to the right reviewers
or responsible parties.

> The get_maintainer.pl script handles staging
> patches just fine today without this being needed at all.

Dubious.

Many of these nominal maintainer email entries are not
found in git logs.

For instance:

$ grep "@" drivers/staging/dt3155/TODO
Please send patches to Greg Kroah-Hartman <greg(a)kroah.com>
and Scott Smedley <ss(a)aao.gov.au>

$ ./scripts/get_maintainer.pl -f drivers/staging/dt3155/
Greg Kroah-Hartman <gregkh(a)suse.de>
Simon Horman <horms(a)verge.net.au>
H Hartley Sweeten <hsweeten(a)visionengravers.com>
devel(a)driverdev.osuosl.org
linux-kernel(a)vger.kernel.org

Some have cc:'d entries, but not many actually have
Signed-off-by's. Perhaps that's because the individuals
are not frequently cc'd on the actual patches. Perhaps
because the people that put their names in the TODO's
just don't care.

> I also found it a bit odd you didn't send these to the stable subsystem
> maintainer, why?

The MAINTAINERS patches are forward going, not historical.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 8 Jun 2010 20:10
On Tue, Jun 08, 2010 at 02:26:22PM -0700, Joe Perches wrote:
> On Tue, 2010-06-08 at 14:12 -0700, Greg KH wrote:
> > On Mon, Jun 07, 2010 at 11:49:34AM -0700, Joe Perches wrote:
> > > Some drivers/staging directories use a TODO file with email entries.
> > > Make the same entries in the normal MAINTAINERS file.
> >
> > No, please don't do this. I don't want to clutter up the MAINTAINERS
> > file with staging stuff.
>
> It's not clutter when it helps get patches to the right reviewers
> or responsible parties.

That's my job as staging maintainer, right? Am I somehow not doing this
properly?

> > The get_maintainer.pl script handles staging
> > patches just fine today without this being needed at all.
>
> Dubious.
>
> Many of these nominal maintainer email entries are not
> found in git logs.

Many, but not all, as you pointed out.

> > I also found it a bit odd you didn't send these to the stable subsystem
> > maintainer, why?
>
> The MAINTAINERS patches are forward going, not historical.

What does that mean?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 8 Jun 2010 20:30
On Tue, 2010-06-08 at 17:07 -0700, Greg KH wrote:
> On Tue, Jun 08, 2010 at 02:26:22PM -0700, Joe Perches wrote:
> > On Tue, 2010-06-08 at 14:12 -0700, Greg KH wrote:
> > > On Mon, Jun 07, 2010 at 11:49:34AM -0700, Joe Perches wrote:
> > > > Some drivers/staging directories use a TODO file with email entries.
> > > > Make the same entries in the normal MAINTAINERS file.
> > > No, please don't do this. I don't want to clutter up the MAINTAINERS
> > > file with staging stuff.
> > It's not clutter when it helps get patches to the right reviewers
> > or responsible parties.
> That's my job as staging maintainer, right? Am I somehow not doing this
> properly?

You can take on all the jobs you want, but automated
tools that allow others to perform those actions and
simultaneously reduce individual workload are better.

> > > I also found it a bit odd you didn't send these to the stable subsystem
> > > maintainer, why?
> > The MAINTAINERS patches are forward going, not historical.
> What does that mean?

It means that relatively few people are developing against
old kernel versions and patches to MAINTAINERS rarely, if
ever, need backporting.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on 9 Jun 2010 09:40
On Wednesday 09 June 2010, Greg KH wrote:
> > > I also found it a bit odd you didn't send these to the stable subsystem
> > > maintainer, why?
> >
> > The MAINTAINERS patches are forward going, not historical.
>
> What does that mean?

I guess you meant to write '... to the /staging/ subsystem maintainer'.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 |  Next  |  Last
Pages: 1 2
Prev: [tip:x86/uv] x86, UV: BAU structure rearranging
Next: [PATCH v2] x86: Unify dumpstack.h and stacktrace.h