Prev: object: is not initialized, yet kobject_put() is being called
Next: BLOCK: fix bio.bi_rw handling
From: Jeff Moyer on 12 Aug 2010 09:30
Jiri Slaby <jslaby(a)suse.cz> writes:

> Commit 74450be1 (block: unify flags for struct bio and struct request)
> added direct test of flags in the & form:
> const bool do_sync = (bio->bi_rw & REQ_SYNC);
> But this doesn't fit into bool with my compiler (gcc 4.5). So change
> the type to ulong to avoid the bug.

At first I wondered why you didn't use the !! trick, but after looking
at the code, I see that the result is |'d into bi_rw.

Looks good. Sounds like it might have been a real bear to track down.

Reviewed-by: Jeff Moyer <jmoyer(a)redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on 12 Aug 2010 12:10
Thanks for sending this again. It's been sent at least twice before,
but we really need to get it into the block tree, and now that it's been
merged to mainline there, too.


Reviewed-by: Christoph Hellwig <hch(a)lst.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: object: is not initialized, yet kobject_put() is being called
Next: BLOCK: fix bio.bi_rw handling