Prev: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config
Next: Slabinfo: Fix display format
From: Gleb O. Raiko on 18 Jun 2010 06:30
On 18.06.2010 14:00, Ralf Baechle wrote:
> static int default_cu2_call(struct notifier_block *nfb, unsigned long action,
> void *data)
> {
> ...
>
> return NOTIFY_OK | NOTIFY_STOP;
NOTIFY_STOP implies NOTIFY_OK, so
return NOTIFY_STOP;
shall be enough.
> }

> The notifier list could also be used for example by perf

Or octeon cop2 handler that just sends NOTIFY_BAD for getting the same
behavior.

Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Ralf Baechle on 18 Jun 2010 08:20
On Fri, Jun 18, 2010 at 02:35:54PM +0400, Gleb O. Raiko wrote:

> >static int default_cu2_call(struct notifier_block *nfb, unsigned long action,
> > void *data)
> >{
> > ...
> >
> > return NOTIFY_OK | NOTIFY_STOP;
> NOTIFY_STOP implies NOTIFY_OK, so
> return NOTIFY_STOP;
> shall be enough.

Correct - I was thinking NOTIFY_STOP_MASK.

> >}
>
> >The notifier list could also be used for example by perf
>
> Or octeon cop2 handler that just sends NOTIFY_BAD for getting the
> same behavior.

Bad karma to return an error for where none happened.

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config
Next: Slabinfo: Fix display format