Prev: [PATCH RFC] perf: fix find_swevent_head() RCU lockdep splat
Next: General questiin about SYSFS
From: Matt Fleming on 13 May 2010 15:00
On Tue, 11 May 2010 14:57:16 -0700, Kevin Hilman <khilman(a)deeprootsystems.com> wrote:
>
> Note that dev_pm_ops version of the suspend hook no longer takes a
> 'state' argument. However, the MMC core function mmc_suspend_host()
> still takes a 'state' argument, but it is unused, so a dummy
> state variable was created to pass to the MMC core.

Hmm.. instead of passing this dummy state argument why don't we just
remove the argument from mmc_suspend_host()? Like you said, it's unused,
so I don't see a reason to keep it around?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Kevin Hilman on 14 May 2010 13:00
Matt Fleming <matt(a)console-pimps.org> writes:

> On Tue, 11 May 2010 14:57:16 -0700, Kevin Hilman <khilman(a)deeprootsystems.com> wrote:
>>
>> Note that dev_pm_ops version of the suspend hook no longer takes a
>> 'state' argument. However, the MMC core function mmc_suspend_host()
>> still takes a 'state' argument, but it is unused, so a dummy
>> state variable was created to pass to the MMC core.
>
> Hmm.. instead of passing this dummy state argument why don't we just
> remove the argument from mmc_suspend_host()? Like you said, it's unused,
> so I don't see a reason to keep it around?

I don't see a reason either, but it requires patching the MMC core as
well as all the users. As I'm not an MMC core person, I thought this
best left to someone in that domain.

Fixing the core and callers could easily be done on top of this patch.

Kevin


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Matt Fleming on 14 May 2010 19:00
On Fri, May 14, 2010 at 09:51:21AM -0700, Kevin Hilman wrote:
>
> I don't see a reason either, but it requires patching the MMC core as
> well as all the users. As I'm not an MMC core person, I thought this
> best left to someone in that domain.
>
> Fixing the core and callers could easily be done on top of this patch.

I've sent a patch that fixes up all the callers now and Andrew has taken
it into -mm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Kevin Hilman on 18 May 2010 12:40
Matt Fleming <matt(a)console-pimps.org> writes:

> On Fri, May 14, 2010 at 09:51:21AM -0700, Kevin Hilman wrote:
>>
>> I don't see a reason either, but it requires patching the MMC core as
>> well as all the users. As I'm not an MMC core person, I thought this
>> best left to someone in that domain.
>>
>> Fixing the core and callers could easily be done on top of this patch.
>
> I've sent a patch that fixes up all the callers now and Andrew has taken
> it into -mm.

Very nice, Thanks.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH RFC] perf: fix find_swevent_head() RCU lockdep splat
Next: General questiin about SYSFS