[MTD] Fix JFFS2 sync silent failure
in [Kernel]
|
Prev: Phylib polling when doing mdio_read will cause system response and transfer speed drop
Next: [Bug #15610] fsck leads to swapper - BUG: unable to handle kernel NULL pointer dereference & panic
From: Jens Axboe on 22 Apr 2010 07:10 On Thu, Apr 22 2010, David Woodhouse wrote: > On Thu, 2010-04-22 at 12:39 +0200, Jens Axboe wrote: > > > > Here's a series for fixing these. At this point they are totally > > untested except that I did compile them. Note that your analysis > > appeared correct for all cases but ocfs2, which does use get_sb_bdev() > > and hence gets ->s_bdi assigned. > > > > You can see them here, I'll post the series soon: > > > > http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=refs/heads/for-linus > > > > The first patch is a helper addition, the rest are per-fs fixups. > > Do you want to include J�rn's addition of same to get_sb_mtd_set(), with > my Acked-By: David Woodhouse <David.Woodhouse(a)intel.com> ? Yeah will do. I also really wanted to provide a WARN and mount fail if we get it wrong, but I don't see an easy way to do that. Basically I'd want to check whether the storage backing is volatile or not. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jörn Engel on 22 Apr 2010 08:00
On Thu, 22 April 2010 12:39:53 +0200, Jens Axboe wrote: > > Here's a series for fixing these. At this point they are totally > untested except that I did compile them. Note that your analysis > appeared correct for all cases but ocfs2, which does use get_sb_bdev() > and hence gets ->s_bdi assigned. > > You can see them here, I'll post the series soon: > > http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=refs/heads/for-linus > > The first patch is a helper addition, the rest are per-fs fixups. Looks good at a cursory glance. What's still missing is some sort of assertion. You are a smart person and missed this problem, twice even. Even if you hadn't, a not so smart person can add a new filesystem and miss s_bdi, like I did. We want some automatism to catch this. Jörn -- "Security vulnerabilities are here to stay." -- Scott Culp, Manager of the Microsoft Security Response Center, 2001 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |