Make __alloc_skb() to get external buffer.
in [Kernel]
|
Prev: Kernel 2.6.32-22-generic sata problems
Next: Export 2 func for device to assign/deassign new strucure
From: Eric Dumazet on 5 Jun 2010 11:00 Le samedi 05 juin 2010 à 18:14 +0800, xiaohui.xin(a)intel.com a écrit : > From: Xin Xiaohui <xiaohui.xin(a)intel.com> > child->fclone = SKB_FCLONE_UNAVAILABLE; > } > + /* Record the external buffer info in this field. It's not so good, > + * but we cannot find another place easily. > + */ > + shinfo->destructor_arg = ext_page; > + Yes this is a big problem, its basically using a cache line that was not touched before. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Xin, Xiaohui on 9 Jun 2010 03:40
>-----Original Message----- >From: Eric Dumazet [mailto:eric.dumazet(a)gmail.com] >Sent: Saturday, June 05, 2010 10:53 PM >To: Xin, Xiaohui >Cc: netdev(a)vger.kernel.org; kvm(a)vger.kernel.org; linux-kernel(a)vger.kernel.org; >mst(a)redhat.com; mingo(a)elte.hu; davem(a)davemloft.net; herbert(a)gondor.apana.org.au; >jdike(a)linux.intel.com >Subject: Re: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer. > >Le samedi 05 juin 2010 � 18:14 +0800, xiaohui.xin(a)intel.com a �crit : >> From: Xin Xiaohui <xiaohui.xin(a)intel.com> >> child->fclone = SKB_FCLONE_UNAVAILABLE; >> } >> + /* Record the external buffer info in this field. It's not so good, >> + * but we cannot find another place easily. >> + */ >> + shinfo->destructor_arg = ext_page; >> + > > >Yes this is a big problem, its basically using a cache line that was not >touched before. > Did your patch which moves destructor_arg before frags[] also fix this? Thanks Xiaohui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |