From: H. Peter Anvin on 17 Dec 2009 17:30 On 12/17/2009 02:09 PM, Sam Ravnborg wrote: > > This is IMO -next fodder and not urgent stuff. > In the distant past something similar caused us troubles. > > I assume that the patch posted by Roland fixes > the relevant troubles with the awk script and that > this patch is just for consistency. > So in other words stuff for -next and not -rc1. > No: the patch Roland posted fixes the problems with non-POSIX-compliant awk (e.g. mawk), but it in turn requires this patch in order to not break on non-C-locale-default systems (which are most systems nowadays.) So -rc1. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Masami Hiramatsu on 17 Dec 2009 18:40 H. Peter Anvin wrote: > On 12/17/2009 02:09 PM, Sam Ravnborg wrote: >> >> This is IMO -next fodder and not urgent stuff. >> In the distant past something similar caused us troubles. >> >> I assume that the patch posted by Roland fixes >> the relevant troubles with the awk script and that >> this patch is just for consistency. >> So in other words stuff for -next and not -rc1. >> > > No: the patch Roland posted fixes the problems with non-POSIX-compliant > awk (e.g. mawk), but it in turn requires this patch in order to not > break on non-C-locale-default systems (which are most systems nowadays.) Right, gawk requires locale setting. btw, something went wrong with it... --- $ make O=/home/mhiramat/kbin/2.6.32 all Using /home/mhiramat/ksrc/linux-2.6-tip as source for kernel GEN /home/mhiramat/kbin/2.6.32/Makefile CHK include/linux/version.h CHK include/linux/utsrelease.h SYMLINK include/asm -> include/asm-x86 CALL /home/mhiramat/ksrc/linux-2.6-tip/scripts/checksyscalls.sh CHK include/linux/compile.h CHK include/linux/version.h make[3]: `scripts/unifdef' ??????? TEST posttest Succeed: decoded and checked 887431 instructions Kernel: arch/x86/boot/bzImage is ready (#19) Building modules, stage 2. MODPOST 434 modules WARNING: modpost: Found 2 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' --- when I ran with LC_ALL=C, it shows message correctly. --- $ make O=/home/mhiramat/kbin/2.6.32 all LC_ALL=C Using /home/mhiramat/ksrc/linux-2.6-tip as source for kernel GEN /home/mhiramat/kbin/2.6.32/Makefile CHK include/linux/version.h CHK include/linux/utsrelease.h SYMLINK include/asm -> include/asm-x86 CALL /home/mhiramat/ksrc/linux-2.6-tip/scripts/checksyscalls.sh CHK include/linux/compile.h CHK include/linux/version.h make[3]: `scripts/unifdef' is up to date. TEST posttest Succeed: decoded and checked 887431 instructions Kernel: arch/x86/boot/bzImage is ready (#19) Building modules, stage 2. MODPOST 434 modules WARNING: modpost: Found 2 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' --- Maybe, "LC_ALL=" line broke it? Thank you, > > So -rc1. > > -hpa -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat(a)redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 17 Dec 2009 18:40 On 12/17/2009 03:34 PM, Masami Hiramatsu wrote: > H. Peter Anvin wrote: >> On 12/17/2009 02:09 PM, Sam Ravnborg wrote: >>> >>> This is IMO -next fodder and not urgent stuff. >>> In the distant past something similar caused us troubles. >>> >>> I assume that the patch posted by Roland fixes >>> the relevant troubles with the awk script and that >>> this patch is just for consistency. >>> So in other words stuff for -next and not -rc1. >>> >> >> No: the patch Roland posted fixes the problems with non-POSIX-compliant >> awk (e.g. mawk), but it in turn requires this patch in order to not >> break on non-C-locale-default systems (which are most systems nowadays.) > > Right, gawk requires locale setting. > > btw, something went wrong with it... > > when I ran with LC_ALL=C, it shows message correctly. > > Maybe, "LC_ALL=" line broke it? > What happens if you remove that part? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Masami Hiramatsu on 17 Dec 2009 18:50 H. Peter Anvin wrote: > On 12/17/2009 03:41 PM, Masami Hiramatsu wrote: >>> >>> What happens if you remove that part? >> >> Commented out LC_ALL= as below; >> > > OK, what about the "unexport" variant? Sure, unexport variant fixed it too. -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat(a)redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on 17 Dec 2009 18:50 On 12/17/2009 03:37 PM, H. Peter Anvin wrote: >> >> Maybe, "LC_ALL=" line broke it? > > What happens if you remove that part? > I mean, of course, the references to LC_ALL. What would be even better, actually, would be to test the following incremental patch: -hpa
|
Next
|
Last
Pages: 1 2 Prev: kernel.h cleanups Next: [PATCH] tracecmd: Add initial python tracecmd API |