Mobile security processor driver
in [Kernel]
|
Prev: NMI & register handling infrastructure - x86 (my first post)
Next: [PATCH 1/5] v4l: Pushdown bkl into video_ioctl2
From: Greg KH on 28 Apr 2010 23:40 On Wed, Apr 28, 2010 at 04:10:52PM -0700, Epshteyn, Eugene wrote: > >From 9230c90ce19747554354c9fc93b3b1c8e661894c Mon Sep 17 00:00:00 2001 > From: Mark Allyn <mark.a.allyn(a)intel.com> > Date: Wed, 28 Apr 2010 14:41:39 -0700 > Subject: RFC [PATCH 4/4] staging: sep: Update TODO Why are you including the patch twice? > --- a/drivers/staging/sep/TODO > +++ b/drivers/staging/sep/TODO <snip> Here's your list of what needs to be done to get this code merged, why have you ignored it when asking us what we thought needed to be done. Isn't this a good enough list of things left to complete? again, totally confused, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 28 Apr 2010 23:40 On Wed, Apr 28, 2010 at 04:10:34PM -0700, Epshteyn, Eugene wrote: > >From ea67f69e70e5a8c6e50db3f1d8b62cd52d816bc6 Mon Sep 17 00:00:00 2001 > From: Mark Allyn <mark.a.allyn(a)intel.com> > Date: Wed, 28 Apr 2010 14:33:16 -0700 > Subject: RFC [PATCH 1/4] staging: sep: header file updates for 12/09 software release > > Signed-off-by: Mark A. Allyn <mark.a.allyn(a)intel.com> Why are you posting Mark's patches? There is no description of what these patches actually do. Are you wanting them to be applied? Why have you listed all of the patches with the same subject? What exactly are you expecting to happen here? totally confused, greg k-h p.s., I think this patch is completly wrong, based on one part: > @@ -25,401 +31,576 @@ > * > * CHANGES: > * > - * 2009.06.26 Initial publish > + * 2010.01.08 Initial publish the code was already published, this can't be an "initial publication" again :) What did you diff these against? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 30 Apr 2010 13:20 A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Apr 29, 2010 at 01:48:25PM -0700, Epshteyn, Eugene wrote: > Hi Greg, > > Mark asked me to post the patches for him. Then say that :) And why would Mark need someone else to do that? > These patches are on 2.6.34 with the 0415 next patch. Then say that :) > We were hoping to get more comments from people to add to TODO list, > so that the vendor can plan their work to fix the issues and make the > driver more acceptable to the community. Isn't Intel the "vendor" here? If not, why not have them directly interact with us, you do not want to be put into the middle, it only slows things down for everyone and is not how Linux kernel development works. > The driver already went through some clean-up, but much more work is > still needed. Yes, that TODO list is quite large already, fix up all of those and then ask for more review please. Reviewing code you know needs lots of work isn't all that nice to do. So again, please fix all of that first, get those changes accepted, and then we can talk :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Epshteyn, Eugene on 30 Apr 2010 13:50 Hi Greg, Mark asked me to post the patches for him. These patches are on 2.6.34 with the 0415 next patch. We were hoping to get more comments from people to add to TODO list, so that the vendor can plan their work to fix the issues and make the driver more acceptable to the community. The driver already went through some clean-up, but much more work is still needed. Thanks, --Eugene -----Original Message----- From: Greg KH [mailto:greg(a)kroah.com] Sent: Wednesday, April 28, 2010 8:36 PM To: Epshteyn, Eugene Cc: linux-kernel(a)vger.kernel.org Subject: Re: [RFC PATCH 1/4] Mobile security processor driver On Wed, Apr 28, 2010 at 04:10:34PM -0700, Epshteyn, Eugene wrote: > >From ea67f69e70e5a8c6e50db3f1d8b62cd52d816bc6 Mon Sep 17 00:00:00 2001 > From: Mark Allyn <mark.a.allyn(a)intel.com> > Date: Wed, 28 Apr 2010 14:33:16 -0700 > Subject: RFC [PATCH 1/4] staging: sep: header file updates for 12/09 software release > > Signed-off-by: Mark A. Allyn <mark.a.allyn(a)intel.com> Why are you posting Mark's patches? There is no description of what these patches actually do. Are you wanting them to be applied? Why have you listed all of the patches with the same subject? What exactly are you expecting to happen here? totally confused, greg k-h p.s., I think this patch is completly wrong, based on one part: > @@ -25,401 +31,576 @@ > * > * CHANGES: > * > - * 2009.06.26 Initial publish > + * 2010.01.08 Initial publish the code was already published, this can't be an "initial publication" again :) What did you diff these against? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Cox on 30 Apr 2010 13:50
> -struct sep_driver_init_t { > - /* start of the 1G of the host memory address that SEP can access */ > - unsigned long message_addr; > + /* new base address */ > + dma_addr_t new_base_addr; > +}; We seem to be going backwards - deformatting code > +static inline u32 SEP_READ_REGISTER(struct device_context *dev, int reg) > +{ > + void __iomem *addr = dev->reg_addr + reg; > + return readl_be(addr); > +} Re adding wrappers > +#define SEP_CHANGE_ENDIANNESS(val) \ > + (((val) >> 24) | (((val) & 0x00FF0000) >> 8) | \ > + (((val) & 0x0000FF00) << 8) | \ > + (((val) & 0x000000FF) << 24)) And other goo > * CHANGES: > * > - * 2009.06.26 Initial publish > + * 2010.01.08 Initial publish Sorry ????? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |