New VACUUM FULL
in [PgSql]
|
From: Tom Lane on 4 Jan 2010 20:35 Robert Haas <robertmhaas(a)gmail.com> writes: > On Mon, Jan 4, 2010 at 3:51 PM, Simon Riggs <simon(a)2ndquadrant.com> wrote: >> Changes required to remove it are at least these places >> >> * most of vacuum.c >> * visibility checks >> * heap tuple flags and xvac >> * nontransactional validation >> * minor points and follow up in >7 files, >12 places > Doesn't sound trivial. The above is a vast overstatement of the problem. Simon is not only talking about removing VACUUM FULL, he's talking about removing every trace that it ever existed, eg deleting support for MOVED_OFF/MOVED_IN tuple status flags. We are *not* doing that, not now nor in the foreseeable future. As long as we have any ambition of having in-place upgrade from pre-8.5 we have to handle the MOVED status bits the same as we do now. AFAICS, ripping out most of the guts of vacuum.c is about all that's likely to happen for 8.5. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 4 Jan 2010 20:53 On Mon, Jan 4, 2010 at 8:35 PM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas(a)gmail.com> writes: >> On Mon, Jan 4, 2010 at 3:51 PM, Simon Riggs <simon(a)2ndquadrant.com> wrote: >>> Changes required to remove it are at least these places >>> >>> * most of vacuum.c >>> * visibility checks >>> * heap tuple flags and xvac >>> * nontransactional validation >>> * minor points and follow up in >7 files, >12 places > >> Doesn't sound trivial. > > The above is a vast overstatement of the problem. Simon is not only > talking about removing VACUUM FULL, he's talking about removing every > trace that it ever existed, eg deleting support for MOVED_OFF/MOVED_IN > tuple status flags. We are *not* doing that, not now nor in the > foreseeable future. As long as we have any ambition of having in-place > upgrade from pre-8.5 we have to handle the MOVED status bits the same as > we do now. > > AFAICS, ripping out most of the guts of vacuum.c is about all that's > likely to happen for 8.5. Well, it sounds like Simon is saying we shouldn't do even that much. Frankly, I'm less concerned with what we're not doing than with what we are doing. From my point of view this VACUUM FULL patch is the most important patch on the table, because it seems that before we can release (1) it has to be committed and then (2) some more work has to be done and committed. We can decide later exactly how far we want to take it and whether to do what you're suggesting here or not; right now I think we should try to keep the focus on moving the current patch forward, since based on what has been said so far, that seems to be on the critical path for 8.5. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 5 Jan 2010 14:01 On Mon, 2010-01-04 at 08:04 +0000, Simon Riggs wrote: > I would prefer this slightly modified version > > 1. Commit your patch, as-is (you/me) I assume this is OK with you now? -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Takahiro Itagaki on 6 Jan 2010 00:41 Simon Riggs <simon(a)2ndQuadrant.com> wrote: > > 1. Commit your patch, as-is (you/me) > > I assume this is OK with you now? I just applied the patch with a few additional comments. Also, I adjusted some messages for vacuumdb to be look-alike for recently-committed --only-analyze patch. Remaining ToDo items are: >> 2. Work on infrastructure for VFC (VACUUM FULL using CLUSTER) for system >> relations (Simon) >> 3. Enable CLUSTER and REINDEX on critical system catalogs (Itagaki) >> 4. Optimise VFC, as discussed earlier (Itagaki) and we might also need: 5. Make CLUSTER VERBOSE to be more verbose because VACUUM FULL VERBOSE is less verbose than VFI VERBOSE for now. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 6 Jan 2010 04:11
On Wed, 2010-01-06 at 14:41 +0900, Takahiro Itagaki wrote: > Simon Riggs <simon(a)2ndQuadrant.com> wrote: > > > > 1. Commit your patch, as-is (you/me) > > > > I assume this is OK with you now? > > I just applied the patch with a few additional comments. > Also, I adjusted some messages for vacuumdb to be look-alike > for recently-committed --only-analyze patch. Perfect, thank you. My morning's work is already done, so onto the next item on the list. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |