From: David Mark on 15 Dec 2009 11:50 On Dec 15, 11:41 am, Matt Kruse <m...(a)thekrusefamily.com> wrote: > On Dec 15, 10:14 am, David Mark <dmark.cins...(a)gmail.com> wrote: > > > Yeah, I told you the new wrappers were slightly improved. Custom (non- > > standard) attribute support is one such improvement. :) > > To quote yourself: > > |You missed that this is obviously broken logic. If one line is > |broken, how do you trust the next (and the thousands that follow that > |one)? No, you have a child-like view of all of this. Missing those two attributes when I slapped together that list of aliases two years ago was a silly omission, which I documented here a long time ago (just never bothered to fix it). Completely botching attributes and properties in a mess like jQuery's attr method is altogether different. ;) > > > > Seems like jQuery gives me the right answers, and "My Library" fails. > > You don't have a clue what the "right" answers are from jQuery as attr > > has no defined behavior. > > I looked at your documentation for getAttribute() and found even less > documentation then attr(). And how many times have I told you that the documentation is incomplete? But it does not betray a complete lack of understanding like jQuery's. Last I checked, they defined attr as retrieving attributes from elements. And, as we know, that's not what it does at all. :) > So I guess returning null in these cases is > just fine, as your method has no defined behavior either. It does have defined behavior. It's a get/setAttribute wrapper that actually works across all IE versions. The only one of its kind AFAIK. ;) > > Pot, Kettle, etc. Not even close.
From: David Mark on 15 Dec 2009 11:58 On Dec 15, 11:45 am, Matt Kruse <m...(a)thekrusefamily.com> wrote: > On Dec 15, 10:23 am, David Mark <dmark.cins...(a)gmail.com> wrote: > > > > $('#x').attr('cellspacing') => 5 > > As this was the only real bug you found [...] > > It took me all of 5 minutes to download your code, look at the code, > and easily identify two problems in the logic. You did not identify any problems in the _logic_. That's the difference. > By your own strict > standards of testing, you've had two years to spot these easily- > identified problems, yet they have remained unfixed in the publicly > downloadable version. Yes, I've stated repeatedly that I abandoned the project for more lucrative ventures. :) So what? It's still light years ahead of jQuery with _nobody_ working on it. > > I'm sure I could find other problems in your code (seeing as how > easily these were found) if I had the desire to look at it, but I > don't. That's a cop-out. If you really wanted a better jQuery, you would have participated in this project two years ago (maybe even spotting those two missing attribute names). But you chose to stick with jQuery through endless rewrites and now you can't upgrade the stupid thing because they've mangled backward compatibility. :) And I looked up the documentation for getAttribute:- "The getAttribute function retrieves the value of the specified attribute of the specified element. Syntax v = getAttribute(el, name); Return Value The function returns a string or null if the specified attribute does not exist." Yep. That's what it does. :) Now what does attr do again? Can Resig define it at all?
From: Matt Kruse on 15 Dec 2009 11:59 On Dec 15, 10:40 am, David Mark <dmark.cins...(a)gmail.com> wrote: > Custom attributes are not supported by that function I must have missed that in the documentation. I guess when calling API.getAttribute() you just don't know what to expect. > I'll bet you don't get that sort of support from the jQuery "team". > Special orders don't upset me. :) Definitely not! Amazing! I guess there are definite advantages to having your code be used by only a handful of users. You can make a release quickly and efficiently without worrying about a release process, backwards compatibility, compatibility with 3rd party code, test cases, examples, documentation, and a huge developer/user community. That must be a big relief. Way to go on that one. Matt Kruse
From: Matt Kruse on 15 Dec 2009 12:04 On Dec 15, 10:50 am, David Mark <dmark.cins...(a)gmail.com> wrote: > No, you have a child-like view of all of this. Missing those two > attributes when I slapped together that list of aliases two years ago > was a silly omission, which I documented here a long time ago (just > never bothered to fix it). > [...] > And how many times have I told you that the documentation is > incomplete? > [...] > > Pot, Kettle, etc. > Not even close. Right. I think the point has been sufficiently made for the archives, so I'm done. Matt Kruse
From: David Mark on 15 Dec 2009 12:12
On Dec 15, 11:59 am, Matt Kruse <m...(a)thekrusefamily.com> wrote: > On Dec 15, 10:40 am, David Mark <dmark.cins...(a)gmail.com> wrote: > > > Custom attributes are not supported by that function > > I must have missed that in the documentation. I guess when calling > API.getAttribute() you just don't know what to expect. Did it say that you can make up any attribute name? Granted, I agree that it should disallow them in the docs, but then I've stated a thousand times that the docs were never finished. Last I heard, somebody was working on updating them and whenever that happens, I'll post the results. > > > I'll bet you don't get that sort of support from the jQuery "team". > > Special orders don't upset me. :) > > Definitely not! Amazing! > > I guess there are definite advantages to having your code be used by > only a handful of users. You haven't got a clue (as usual). > You can make a release quickly and > efficiently without worrying about a release process, What do you know about my release process? I'll tell you that one thing I always do is to run the script through JSLint. As there are only a half dozen things it flags, it is easy to spot typos. Now, as jQuery has so many failings that the lint quits prematurely, it is not possible to spot typos like this at all. > backwards > compatibility, compatibility with 3rd party code, All ridiculous. Adding those two alias isn't going to break anything. > test cases, As you well know, I wrote the proverbial book on attribute-related test cases:- http://www.cinsoft.net/attributes.html > examples, documentation, The documentation for that method is correct (and it has an example). > and a huge developer/user community. > That > must be a big relief. Way to go on that one. You come off like a petulant child. Just face it, you were wrong all along. Do I have to go back two years and dig up all of the similar discussions between you, me and Resig? Didn't I tell you he would have to rewrite everything _and_ break compatibility badly to "keep up" with the new browsers (specifically IE8). And didn't I tell you that feature testing (as used in mine) was the key to avoiding such problems. Look at yourself, stuck with a two-year-old version of jQuery, because they _broke_ compatibility (and fixed almost _nothing_ in doing so). Way to go, indeed. :) |