Prev: trivial: fix typos concerning "initiali[zs]e"
Next: N-Trig improved filtering
From: Kristoffer Glembo on 11 May 2010 04:40
Miguel Ojeda wrote:
> On Sat, May 8, 2010 at 11:58 PM, Miguel Ojeda
> <miguel.ojeda.sandonis(a)gmail.com> wrote:
>> Hi,
>>
>> I found two problems using the Simics' sunfire target, so maybe the
>> following does not occur in real machines.
>>
>> 1. At grlib_apbuart_configure() in apbuart.c, prop can be NULL if
>> "clock-frequency" doesn't exist in the OF tree:
>>
>> /* Get bus frequency */
>> rp = of_find_node_by_path("/");
>> rp = of_get_next_child(rp, NULL);
>> prop = of_get_property(rp, "clock-frequency", NULL);
>> freq_khz = *prop;
>>
>> 2. In addition, apbuart.c does not check if there aren't any ports
>> configured after calls to grlib_apbuart_configure(), so other oops will
>> occur if no port was configured (e.g. uart_set_options() because of
>> port->ops).
>>
>> In order to solve that, I added a check after both of the calls to
>> grlib_apbuart_configure().
>>
>> The patch that I provide below prevents both problems in the Simics'
>> sunfire target.
>>
>> Tested against 2.6.33.3. Please review.
>>
>> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis(a)gmail.com>


Thanks for the patch, it looks fine to me.

Acked-by: Kristoffer Glembo <kristoffer(a)gaisler.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: trivial: fix typos concerning "initiali[zs]e"
Next: N-Trig improved filtering