Prev: GPIO: rdc321x fix inverted gpio data out registers
Next: x86/mrst: add nop functions to x86_init mpparse functions
From: Carsten Emde on 16 May 2010 18:30
Hi Ingo,

> The whole enumeration there is pointless in that .c file - it tells nothing
> to the code reader.

> If it cannot be expressed in a meaningful way then introduce
> TASK_STATE_STRINGS_INIT construct that is defined next to the strings (in a
> .h file or so) - that way it's a coherent whole.
The updated patch
- has all definitions at a common place,
- adapts the related comment,
- makes the string array declaration in fs/proc/array.c a one-liner.

Carsten.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: GPIO: rdc321x fix inverted gpio data out registers
Next: x86/mrst: add nop functions to x86_init mpparse functions