Prev: [PATCH 03/11] rwsem: fully separate code pathes to wake writers vs readers
Next: [PATCH 06/11] rwsem: wake queued readers when writer blocks on active read lock
From: Michel Lespinasse on 24 May 2010 16:40
When count>0 there is no need to take the call_rwsem_wake path.
If we did take that path, it would just return without doing anything
due to the active count not being zero.

Signed-off-by: Michel Lespinasse <walken(a)google.com>
Acked-by: David Howells <dhowells(a)redhat.com>
---
arch/x86/include/asm/rwsem.h | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/rwsem.h b/arch/x86/include/asm/rwsem.h
index 606ede1..3fd1ed3 100644
--- a/arch/x86/include/asm/rwsem.h
+++ b/arch/x86/include/asm/rwsem.h
@@ -216,9 +216,8 @@ static inline void __up_write(struct rw_semaphore *sem)
rwsem_count_t tmp;
asm volatile("# beginning __up_write\n\t"
LOCK_PREFIX " xadd %1,(%2)\n\t"
- /* tries to transition
- 0xffff0001 -> 0x00000000 */
- " jz 1f\n"
+ /* substracts 0xffff0001, returns the old value */
+ " jns 1f\n\t"
" call call_rwsem_wake\n"
"1:\n\t"
"# ending __up_write\n"
--
1.7.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 03/11] rwsem: fully separate code pathes to wake writers vs readers
Next: [PATCH 06/11] rwsem: wake queued readers when writer blocks on active read lock