Prev: [PATCH 15/15] sound/soc: imx: check kzalloc() result and fix memory leak
Next: [PATCH 06/15] staging: tidspbridge: check kmalloc() result
From: Kulikov Vasiliy on 16 Jul 2010 12:20
Scale down spin_lock_irqsave/spin_unlock_irqrestore exactly to area
where it is needed. Also it makes static checkers happy as code checks
kmalloc() result value exactly after call.

Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
---
arch/alpha/kernel/srmcons.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/alpha/kernel/srmcons.c b/arch/alpha/kernel/srmcons.c
index 783f4e5..6b04005 100644
--- a/arch/alpha/kernel/srmcons.c
+++ b/arch/alpha/kernel/srmcons.c
@@ -165,17 +165,15 @@ srmcons_get_private_struct(struct srmcons_private **ps)

if (srmconsp == NULL) {
srmconsp = kmalloc(sizeof(*srmconsp), GFP_KERNEL);
- spin_lock_irqsave(&srmconsp_lock, flags);
-
if (srmconsp == NULL)
retval = -ENOMEM;
else {
+ spin_lock_irqsave(&srmconsp_lock, flags);
srmconsp->tty = NULL;
spin_lock_init(&srmconsp->lock);
init_timer(&srmconsp->timer);
+ spin_unlock_irqrestore(&srmconsp_lock, flags);
}
-
- spin_unlock_irqrestore(&srmconsp_lock, flags);
}

*ps = srmconsp;
--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 15/15] sound/soc: imx: check kzalloc() result and fix memory leak
Next: [PATCH 06/15] staging: tidspbridge: check kmalloc() result