[PATCH 04/10] drivers/hwmon/vt8231.c: Fix continuation line formats
in [Kernel]
|
Prev: [PATCH 18/28] asus-laptop: add error check for write_acpi_int calls
Next: [PATCH 09/28] asus-laptop: move backlight and dsdt info inside asus_laptop struct
From: Jean Delvare on 2 Feb 2010 03:00 Hi Joe, On Mon, 1 Feb 2010 23:22:10 -0800, Joe Perches wrote: > String constants that are continued on subsequent lines with \ > are not good. > > Signed-off-by: Joe Perches <joe(a)perches.com> > --- > drivers/hwmon/vt8231.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c > index d47b4c9..e6078c9 100644 > --- a/drivers/hwmon/vt8231.c > +++ b/drivers/hwmon/vt8231.c > @@ -948,8 +948,7 @@ static int __devinit vt8231_pci_probe(struct pci_dev *dev, > > address = val & ~(VT8231_EXTENT - 1); > if (address == 0) { > - dev_err(&dev->dev, "base address not set -\ > - upgrade BIOS or use force_addr=0xaddr\n"); > + dev_err(&dev->dev, "base address not set - upgrade BIOS or use force_addr=0xaddr\n"); > return -ENODEV; > } > Good catch, and thanks for the fix. But now we have an overlong line, which checkpatch will complain about. So I would prefer if you'd fix the problem by replacing the \ by a pair of ". -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 2 Feb 2010 03:10
On Tue, 2010-02-02 at 08:56 +0100, Jean Delvare wrote: > > diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c > > index d47b4c9..e6078c9 100644 > > --- a/drivers/hwmon/vt8231.c > > +++ b/drivers/hwmon/vt8231.c > > @@ -948,8 +948,7 @@ static int __devinit vt8231_pci_probe(struct pci_dev *dev, > > > > address = val & ~(VT8231_EXTENT - 1); > > if (address == 0) { > > - dev_err(&dev->dev, "base address not set -\ > > - upgrade BIOS or use force_addr=0xaddr\n"); > > + dev_err(&dev->dev, "base address not set - upgrade BIOS or use force_addr=0xaddr\n"); > > return -ENODEV; > > } > > > > Good catch, and thanks for the fix. But now we have an overlong line, > which checkpatch will complain about. So I would prefer if you'd fix > the problem by replacing the \ by a pair of ". That depends on what version of checkpatch you're using. There's one with a pr_<level> and dev_<level> exemption to the long line check. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |