Prev: [PATCH 9/9] sound/soc/codecs: Correct code taking the size of a pointer
Next: 2.6.32-git5+, CONFIG_WEXT_PRIV and Broadcom's driver for BCM4322 Wireless chips
From: Frederic Weisbecker on 13 Dec 2009 08:10
From: Li Zefan <lizf(a)cn.fujitsu.com>

I found a weird behavior:

# echo 'fuse:*' > set_ftrace_filter
bash: echo: write error: Invalid argument
# cat set_ftrace_filter
fuse_dev_fasync
fuse_dev_poll
fuse_copy_do

We should call trace_parser_clear() no matter ftrace_process_regex()
returns 0 or -errno, otherwise we will actually take the unaccepted
records from ftrace_regex_release().

Signed-off-by: Li Zefan <lizf(a)cn.fujitsu.com>
Acked-by: Steven Rostedt <rostedt(a)goodmis.org>
LKML-Reference: <4B1DC4D2.3000406(a)cn.fujitsu.com>
Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com>
---
kernel/trace/ftrace.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 08a3fb5..ff8aecd 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2208,10 +2208,9 @@ ftrace_regex_write(struct file *file, const char __user *ubuf,
!trace_parser_cont(parser)) {
ret = ftrace_process_regex(parser->buffer,
parser->idx, enable);
+ trace_parser_clear(parser);
if (ret)
goto out_unlock;
-
- trace_parser_clear(parser);
}

ret = read;
--
1.6.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 9/9] sound/soc/codecs: Correct code taking the size of a pointer
Next: 2.6.32-git5+, CONFIG_WEXT_PRIV and Broadcom's driver for BCM4322 Wireless chips