Prev: [PATCH 05/11] staging: crystalhd: clean up crystalhd_setup_cmd_context() return code
Next: [PATCH 09/11] staging: crystalhd: clean up crystalhd_put_ddr2sleep() return code
From: Yoichi Yuasa on 25 Apr 2010 09:50 Signed-off-by: Yoichi Yuasa <yuasa(a)linux-mips.org> --- drivers/staging/crystalhd/crystalhd_cmds.c | 6 ++---- drivers/staging/crystalhd/crystalhd_cmds.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c index bfa11df..d341876 100644 --- a/drivers/staging/crystalhd/crystalhd_cmds.c +++ b/drivers/staging/crystalhd/crystalhd_cmds.c @@ -913,7 +913,7 @@ BC_STATUS crystalhd_user_open(struct crystalhd_cmd *ctx, * Closer aplication handle and release app specific * resources. */ -BC_STATUS crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc) +void crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc) { uint32_t mode = uc->mode; @@ -928,14 +928,12 @@ BC_STATUS crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user crystalhd_hw_free_dma_rings(&ctx->hw_ctx); crystalhd_destroy_dio_pool(ctx->adp); } else if (bc_cproc_get_user_count(ctx)) { - return BC_STS_SUCCESS; + return; } crystalhd_hw_close(&ctx->hw_ctx); ctx->state = BC_LINK_INVALID; - - return BC_STS_SUCCESS; } /** diff --git a/drivers/staging/crystalhd/crystalhd_cmds.h b/drivers/staging/crystalhd/crystalhd_cmds.h index ea1b0d4..026a07e 100644 --- a/drivers/staging/crystalhd/crystalhd_cmds.h +++ b/drivers/staging/crystalhd/crystalhd_cmds.h @@ -80,7 +80,7 @@ BC_STATUS crystalhd_resume(struct crystalhd_cmd *ctx); crystalhd_cmd_proc crystalhd_get_cmd_proc(struct crystalhd_cmd *ctx, uint32_t cmd, struct crystalhd_user *uc); BC_STATUS crystalhd_user_open(struct crystalhd_cmd *ctx, struct crystalhd_user **user_ctx); -BC_STATUS crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc); +void crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc); int crystalhd_setup_cmd_context(struct crystalhd_cmd *ctx, struct crystalhd_adp *adp); void crystalhd_delete_cmd_context(struct crystalhd_cmd *ctx); bool crystalhd_cmd_interrupt(struct crystalhd_cmd *ctx); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |