Prev: block/io bits for 2.6.35-rc
Next: [GIT PULL 0/1] perf/core Improvement for 2.6.36
From: Arnaldo Carvalho de Melo on 10 Jun 2010 12:10
From: Arnaldo Carvalho de Melo <acme(a)redhat.com>

When processing events we want to give visual feedback to the user when
using the newt browser, so there are ui_progress calls in
__perf_session__process_events, but those should check if newt is being
used.

Reported-by: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com>
Tested-by: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth(a)in.ibm.com>
Cc: Frédéric Weisbecker <fweisbec(a)gmail.com>
Cc: Ingo Molnar <mingo(a)elte.hu>
Cc: Masami Hiramatsu <masami.hiramatsu.pt(a)hitachi.com>,
Cc: Peter Zijlstra <peterz(a)infradead.org>
Cc: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com>
Cc: Stephane Eranian <eranian(a)google.com>
Cc: Tom Zanussi <tzanussi(a)gmail.com>
LKML-Reference: <20100609123530.GB9471(a)ghostprotocols.net>
Signed-off-by: Arnaldo Carvalho de Melo <acme(a)redhat.com>
---
tools/perf/util/newt.c | 15 +++++++++++++--
1 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c
index cf182ca..7537ca1 100644
--- a/tools/perf/util/newt.c
+++ b/tools/perf/util/newt.c
@@ -43,6 +43,9 @@ struct ui_progress *ui_progress__new(const char *title, u64 total)

if (self != NULL) {
int cols;
+
+ if (use_browser <= 0)
+ return self;
newtGetScreenSize(&cols, NULL);
cols -= 4;
newtCenteredWindow(cols, 1, title);
@@ -67,14 +70,22 @@ out_free_self:

void ui_progress__update(struct ui_progress *self, u64 curr)
{
+ /*
+ * FIXME: We should have a per UI backend way of showing progress,
+ * stdio will just show a percentage as NN%, etc.
+ */
+ if (use_browser <= 0)
+ return;
newtScaleSet(self->scale, curr);
newtRefresh();
}

void ui_progress__delete(struct ui_progress *self)
{
- newtFormDestroy(self->form);
- newtPopWindow();
+ if (use_browser > 0) {
+ newtFormDestroy(self->form);
+ newtPopWindow();
+ }
free(self);
}

--
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: block/io bits for 2.6.35-rc
Next: [GIT PULL 0/1] perf/core Improvement for 2.6.36