[PATCH 1/5] oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads
in [Kernel]
|
Prev: [PATCH 3/5] oom: introduce find_lock_task_mm() to fix !mm false positives
Next: [PATCH 4/5] oom: the points calculation of child processes must use find_lock_task_mm() too
From: KOSAKI Motohiro on 31 May 2010 05:40 From: Oleg Nesterov <oleg(a)redhat.com> Subject: oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads select_bad_process() thinks a kernel thread can't have ->mm != NULL, this is not true due to use_mm(). Change the code to check PF_KTHREAD. Signed-off-by: Oleg Nesterov <oleg(a)redhat.com> Acked-by: David Rientjes <rientjes(a)google.com> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> --- mm/oom_kill.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 709aedf..070b713 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -256,14 +256,11 @@ static struct task_struct *select_bad_process(unsigned long *ppoints, for_each_process(p) { unsigned long points; - /* - * skip kernel threads and tasks which have already released - * their mm. - */ + /* skip the tasks which have already released their mm. */ if (!p->mm) continue; - /* skip the init task */ - if (is_global_init(p)) + /* skip the init task and kthreads */ + if (is_global_init(p) || (p->flags & PF_KTHREAD)) continue; if (mem && !task_in_mem_cgroup(p, mem)) continue; -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |