[PATCH 1/5] percpu: add sanity check for UP
in [Kernel]
|
Prev: [PATCH 5/5] percpu: add missing markups in arch/x86/lib/msr*
Next: [PATCH 3/5] percpu: add missing markups in kernel/workqueue.c
From: Namhyung Kim on 6 Aug 2010 14:30 add sanity check for percpu accessors on UP. This removes lots of sparse warnings. Signed-off-by: Namhyung Kim <namhyung(a)gmail.com> --- include/asm-generic/percpu.h | 12 +++++++++--- include/linux/percpu.h | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/include/asm-generic/percpu.h b/include/asm-generic/percpu.h index b5043a9..50ac3ac 100644 --- a/include/asm-generic/percpu.h +++ b/include/asm-generic/percpu.h @@ -70,9 +70,15 @@ extern void setup_per_cpu_areas(void); #else /* ! SMP */ -#define per_cpu(var, cpu) (*((void)(cpu), &(var))) -#define __get_cpu_var(var) (var) -#define __raw_get_cpu_var(var) (var) +#define VERIFY_PERCPU_PTR(__p) ({ \ + __verify_pcpu_ptr((__p)); \ + (typeof(*(__p)) __kernel __force *) (__p); \ +}) + +#define per_cpu(var, cpu) \ + (*((void)(cpu), VERIFY_PERCPU_PTR(&(var)))) +#define __get_cpu_var(var) (*VERIFY_PERCPU_PTR(&(var))) +#define __raw_get_cpu_var(var) (*VERIFY_PERCPU_PTR(&(var))) #define this_cpu_ptr(ptr) per_cpu_ptr(ptr, 0) #define __this_cpu_ptr(ptr) this_cpu_ptr(ptr) diff --git a/include/linux/percpu.h b/include/linux/percpu.h index d3a38d6..bc36301 100644 --- a/include/linux/percpu.h +++ b/include/linux/percpu.h @@ -143,7 +143,7 @@ extern void __init setup_per_cpu_areas(void); #else /* CONFIG_SMP */ -#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); (ptr); }) +#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR((ptr)); }) /* can't distinguish from other static vars, always false */ static inline bool is_kernel_percpu_address(unsigned long addr) -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |