Prev: [PATCH 01/31] stallion: prune lock_kernel calls
Next: [PATCH 5/6] usb/gadget: Do not take BKL for gadget->ops->ioctl
From: Arnd Bergmann on 1 Jun 2010 17:10
From: Andi Kleen <ak(a)linux.intel.com>

The code this is attempting to lock against does not use the BKL,
so it's not needed.

Most likely this code is still broken/racy (Al Viro also thinks so),
but removing the BKL should not make it worse than before.

Signed-off-by: Andi Kleen <ak(a)linux.intel.com>
---
drivers/usb/core/inode.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c
index 1a27618..095fa53 100644
--- a/drivers/usb/core/inode.c
+++ b/drivers/usb/core/inode.c
@@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data)
return -EINVAL;
}

- lock_kernel();
-
if (usbfs_mount && usbfs_mount->mnt_sb)
update_sb(usbfs_mount->mnt_sb);

- unlock_kernel();
-
return 0;
}

--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 01/31] stallion: prune lock_kernel calls
Next: [PATCH 5/6] usb/gadget: Do not take BKL for gadget->ops->ioctl