Prev: [PATCH 17/18] vfs: don't use BKL in default_llseek
Next: [PATCH 04/18] ib/qib: use generic_file_llseek
From: Arnd Bergmann on 7 Jul 2010 17:50
The event buffer cannot deal with seeks, so
we should forbid that outright.

Signed-off-by: Arnd Bergmann <arnd(a)arndb.de>
Cc: Robert Richter <robert.richter(a)amd.com>
Cc: oprofile-list(a)lists.sf.net
---
drivers/oprofile/event_buffer.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/oprofile/event_buffer.c b/drivers/oprofile/event_buffer.c
index 5df60a6..dd87e86 100644
--- a/drivers/oprofile/event_buffer.c
+++ b/drivers/oprofile/event_buffer.c
@@ -135,7 +135,7 @@ static int event_buffer_open(struct inode *inode, struct file *file)
* echo 1 >/dev/oprofile/enable
*/

- return 0;
+ return nonseekable_open(inode, file);

fail:
dcookie_unregister(file->private_data);
@@ -205,4 +205,5 @@ const struct file_operations event_buffer_fops = {
.open = event_buffer_open,
.release = event_buffer_release,
.read = event_buffer_read,
+ .llseek = no_llseek,
};
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 17/18] vfs: don't use BKL in default_llseek
Next: [PATCH 04/18] ib/qib: use generic_file_llseek