Prev: [PATCH 09/18] sysctl extern cleanup - file nr
Next: [PATCH 08/18] sysctl extern cleanup - latencytop
From: Dave Young on 20 Feb 2010 09:20 Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files. Move sg_big_buff extern declaration to scsi/sg.h Signed-off-by: Dave Young <hidave.darkstar(a)gmail.com> --- include/scsi/sg.h | 5 +++++ kernel/sysctl.c | 5 +---- 2 files changed, 6 insertions(+), 4 deletions(-) --- linux-2.6.32.orig/include/scsi/sg.h 2010-02-20 14:02:18.708258892 +0800 +++ linux-2.6.32/include/scsi/sg.h 2010-02-20 14:39:48.631369361 +0800 @@ -70,6 +70,11 @@ Major new features in SG 3.x driver (cf (for the lk 2.2 series). */ +#ifdef __KERNEL__ +#if defined(CONFIG_SYSCTL) && defined(CONFIG_CHR_DEV_SG) +extern int sg_big_buff; +#endif +#endif /* New interface introduced in the 3.x SG drivers follows */ --- linux-2.6.32.orig/kernel/sysctl.c 2010-02-20 14:27:50.691439411 +0800 +++ linux-2.6.32/kernel/sysctl.c 2010-02-20 14:38:51.008872869 +0800 @@ -62,6 +62,7 @@ #include <linux/latencytop.h> #include <linux/file.h> #include <linux/blk-iopoll.h> +#include <scsi/sg.h> #include <asm/uaccess.h> #include <asm/processor.h> @@ -100,10 +101,6 @@ static int min_percpu_pagelist_fract = 8 static int ngroups_max = NGROUPS_MAX; -#ifdef CONFIG_CHR_DEV_SG -extern int sg_big_buff; -#endif - #ifdef CONFIG_SPARC #include <asm/system.h> #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |