Prev: [PATCH v2 1/3] EEPROM: Header file cleanup
Next: [PATCH 7/20] drivers/usb/serial: Use kzalloc
From: Julia Lawall on 13 May 2010 16:10
From: Julia Lawall <julia(a)diku.dk>

Use kzalloc rather than the combination of kmalloc and memset.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,size,flags;
statement S;
@@

-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
if (x == NULL) S
-memset(x, 0, size);
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>

---
drivers/net/vmxnet3/vmxnet3_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff -u -p a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1369,13 +1369,12 @@ vmxnet3_rq_create(struct vmxnet3_rx_queu

sz = sizeof(struct vmxnet3_rx_buf_info) * (rq->rx_ring[0].size +
rq->rx_ring[1].size);
- bi = kmalloc(sz, GFP_KERNEL);
+ bi = kzalloc(sz, GFP_KERNEL);
if (!bi) {
printk(KERN_ERR "%s: failed to allocate rx bufinfo\n",
adapter->netdev->name);
goto err;
}
- memset(bi, 0, sz);
rq->buf_info[0] = bi;
rq->buf_info[1] = bi + rq->rx_ring[0].size;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Bhavesh Davda on 13 May 2010 17:30
Looks good. Thanks for doing this!

Signed-off-by: Bhavesh Davda <bhavesh(a)vmware.com>

- Bhavesh

Bhavesh P. Davda

> -----Original Message-----
> From: pv-drivers-bounces(a)vmware.com [mailto:pv-drivers-
> bounces(a)vmware.com] On Behalf Of Julia Lawall
> Sent: Thursday, May 13, 2010 1:06 PM
> To: Shreyas Bhatewara; VMware, Inc.; netdev(a)vger.kernel.org; linux-
> kernel(a)vger.kernel.org; kernel-janitors(a)vger.kernel.org
> Subject: [Pv-drivers] [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc
>
> From: Julia Lawall <julia(a)diku.dk>
>
> Use kzalloc rather than the combination of kmalloc and memset.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,size,flags;
> statement S;
> @@
>
> -x = kmalloc(size,flags);
> +x = kzalloc(size,flags);
> if (x == NULL) S
> -memset(x, 0, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia(a)diku.dk>
>
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1369,13 +1369,12 @@ vmxnet3_rq_create(struct vmxnet3_rx_queu
>
> sz = sizeof(struct vmxnet3_rx_buf_info) * (rq->rx_ring[0].size +
> rq->rx_ring[1].size);
> - bi = kmalloc(sz, GFP_KERNEL);
> + bi = kzalloc(sz, GFP_KERNEL);
> if (!bi) {
> printk(KERN_ERR "%s: failed to allocate rx bufinfo\n",
> adapter->netdev->name);
> goto err;
> }
> - memset(bi, 0, sz);
> rq->buf_info[0] = bi;
> rq->buf_info[1] = bi + rq->rx_ring[0].size;
>
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers(a)vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH v2 1/3] EEPROM: Header file cleanup
Next: [PATCH 7/20] drivers/usb/serial: Use kzalloc