Prev: [PATCH 5/17] drivers/media/video/pvrusb2: Add missing mutex_unlock
Next: [PATCH] do_generic_file_read: clear page errors when issuing a fresh read of the page
From: Julia Lawall on 26 May 2010 12:00
From: Julia Lawall <julia(a)diku.dk>

Add a spin_unlock missing on the error path. Unlock as in the other code
that leads to the leave label.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E1;
@@

* spin_lock(E1,...);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* spin_unlock(E1,...);
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>

---
fs/ocfs2/dlm/dlmdomain.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c
index 6b5a492..2ccad86 100644
--- a/fs/ocfs2/dlm/dlmdomain.c
+++ b/fs/ocfs2/dlm/dlmdomain.c
@@ -1709,6 +1709,7 @@ retry:
}

if (dlm_protocol_compare(&dlm->fs_locking_proto, fs_proto)) {
+ spin_unlock(&dlm_domain_lock);
mlog(ML_ERROR,
"Requested locking protocol version is not "
"compatible with already registered domain "
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 5/17] drivers/media/video/pvrusb2: Add missing mutex_unlock
Next: [PATCH] do_generic_file_read: clear page errors when issuing a fresh read of the page