Prev: [PATCH 1/12] arch/powerpc/kernel: Add missing unlock
Next: [RFC] Xilinx MPMC SDMA subsystem
From: Julia Lawall on 29 Mar 2010 11:40
From: Julia Lawall <julia(a)diku.dk>

In the default case the lock is not unlocked. The return is
converted to a goto, to share the unlock at the end of the function.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E1;
identifier f;
@@

f (...) { <+...
* spin_lock_irq (E1,...);
.... when != E1
* return ...;
....+> }
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>

---
arch/s390/kernel/topology.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c
index 14ef6f0..247b4c2 100644
--- a/arch/s390/kernel/topology.c
+++ b/arch/s390/kernel/topology.c
@@ -165,10 +165,11 @@ static void tl_to_cores(struct tl_info *info)
default:
clear_cores();
machine_has_topology = 0;
- return;
+ goto out;
}
tle = next_tle(tle);
}
+out:
spin_unlock_irq(&topology_lock);
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/12] arch/powerpc/kernel: Add missing unlock
Next: [RFC] Xilinx MPMC SDMA subsystem