Prev: [PATCHv2 4/5] mtd: mxc_nand fixups
Next: [PATCH 1/2] drivers/hid: Eliminate a double lock
From: Julia Lawall on 20 Jun 2010 07:30
From: Julia Lawall <julia(a)diku.dk>

The function begins and ends with a read_lock. The latter is changed to a
read_unlock.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@locked@
expression E1;
position p;
@@

read_lock(E1@p,...);

@r exists@
expression x <= locked.E1;
expression locked.E1;
expression E2;
identifier lock;
position locked.p,p1,p2;
@@

*lock(a)p1 (E1@p,...);
.... when != E1
when != \(x = E2\|&x\)
*lock(a)p2 (E1,...);
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>

---
Not tested

arch/sh/mm/pmb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/mm/pmb.c b/arch/sh/mm/pmb.c
index 18623ba..6379091 100644
--- a/arch/sh/mm/pmb.c
+++ b/arch/sh/mm/pmb.c
@@ -770,7 +770,7 @@ static void __init pmb_resize(void)
spin_unlock_irqrestore(&pmbe->lock, flags);
}

- read_lock(&pmb_rwlock);
+ read_unlock(&pmb_rwlock);
}
#endif

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCHv2 4/5] mtd: mxc_nand fixups
Next: [PATCH 1/2] drivers/hid: Eliminate a double lock