Prev: [PATCH 2/9] vfs: Add name to file handle conversion support
Next: [PATCH 5/9] vfs: Support null pathname in readlink
From: Joel Becker on 6 Jul 2010 14:50 On Tue, Jul 06, 2010 at 12:09:19AM -0700, Joel Becker wrote: > On Sun, Jul 04, 2010 at 11:13:01PM +0800, Tao Ma wrote: > > > if (new) { > > > wc->w_num_pages = ocfs2_pages_per_cluster(inode->i_sb); > > > start = ocfs2_align_clusters_to_page_index(inode->i_sb, cpos); > > >+ /* This is the index *past* the write */ > > >+ end_index = ((user_pos + user_len)>> PAGE_CACHE_SHIFT) + 1; > > should it be > > end_index = ((user_pos + user_len - 1) >> PAGE_CACHE_SHIFT) + 1? > > Maybe. Gotta think about it and test. I think you're right. Since there are other changes too, I'm going to add this in and test it. Joel -- "I'm drifting and drifting Just like a ship out on the sea. Cause I ain't got nobody, baby, In this world to care for me." Joel Becker Consulting Software Developer Oracle E-mail: joel.becker(a)oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |