Prev: [PATCH] fs: make sure to invalidate pages if we fall back on buffered reads
Next: Fwd: [rtc-linux] RTC_SET_TIME: Inappropriate ioctl for device
From: Miklos Szeredi on 8 Jun 2010 10:40
From: Miklos Szeredi <mszeredi(a)suse.cz>

As it stands this check compares the number of pages to the page size.
This makes no sense and makes the fcntl fail in almost any sane case.

Fix it by removing the check completely, round_pipe_size() will make
sure that nr_pages >= 1 anyway.

Signed-off-by: Miklos Szeredi <mszeredi(a)suse.cz>
---
fs/pipe.c | 3 ---
1 file changed, 3 deletions(-)

Index: linux-2.6/fs/pipe.c
===================================================================
--- linux-2.6.orig/fs/pipe.c 2010-06-08 14:14:59.000000000 +0200
+++ linux-2.6/fs/pipe.c 2010-06-08 14:22:45.000000000 +0200
@@ -1211,9 +1211,6 @@ long pipe_fcntl(struct file *file, unsig
if (!capable(CAP_SYS_RESOURCE) && size > pipe_max_size) {
ret = -EPERM;
goto out;
- } else if (nr_pages < PAGE_SIZE) {
- ret = -EINVAL;
- goto out;
}
ret = pipe_set_size(pipe, nr_pages);
break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] fs: make sure to invalidate pages if we fall back on buffered reads
Next: Fwd: [rtc-linux] RTC_SET_TIME: Inappropriate ioctl for device