[PATCH 2/4] Checkpatch: prefer usleep_range over udelay
in [Kernel]
|
Prev: [PATCH 0/4 -tip] delay documentation and checkpatch additions
Next: [PATCH 1/4] Documentation: Add timers/delays.txt
From: Patrick Pannuto on 27 Jul 2010 18:50 When possible, sleeping is (usually) better than delaying, however, don't bother callers of udelay < 10us, as those cases are not with the switch to usleep_range Signed-off-by: Patrick Pannuto <ppannuto(a)codeaurora.org> --- scripts/checkpatch.pl | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bd88f11..e3625ac 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2570,6 +2570,14 @@ sub process { } } +# prefer usleep_range over udelay + if ($line =~ /\budelay\s*\((.+)\);/) { + # ignore udelay's < 10, however + if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) { + WARN("usleep_range is preferred over udelay; see Documentation/timers/delays.txt\n" . $line); + } + } + # warn about #ifdefs in C files # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { # print "#ifdef in C files should be avoided\n"; -- 1.7.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |