[PATCH 2/9] drivers/scsi/qla2xxx/qla_init.c: Drop unnecessary null test
in [Kernel]
|
Prev: [PATCH 2/2] genhd, efi: add efi partition metadata to hd_structs
Next: [PATCH 1/2] block, partition: add partition_meta_info to hd_struct
From: Julia Lawall on 3 Aug 2010 17:40 From: Julia Lawall <julia(a)diku.dk> list_for_each_entry binds its first argument to a non-null value, and thus any null test on the value of that argument is superfluous. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ iterator I; expression x,E; @@ I(x,...) { <... - (x != NULL) && E ...> } // </smpl> Signed-off-by: Julia Lawall <julia(a)diku.dk> --- drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index d863ed2..9c6af9c 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -3796,7 +3796,7 @@ qla2x00_update_fcports(scsi_qla_host_t *base_vha) /* Go with deferred removal of rport references. */ list_for_each_entry_safe(vha, tvp, &base_vha->hw->vp_list, list) list_for_each_entry(fcport, &vha->vp_fcports, list) - if (fcport && fcport->drport && + if (fcport->drport && atomic_read(&fcport->state) != FCS_UNCONFIGURED) qla2x00_rport_del(fcport); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |