[PATCH 3/3] lib: fix atomic64_add_unless return value convention
in [Kernel]
|
Prev: x86: Fix out of order gsi -- add remap_ioapic_gsi_to_irq()
Next: [PATCH 2/3] x86: fix atomic64_add_unless return value convention
From: Luca Barbieri on 1 Mar 2010 12:20 The 0 and 1 return values were incorrectly swapped. Reported-by: H. Peter Anvin <hpa(a)zytor.com> Signed-off-by: Luca Barbieri <luca(a)luca-barbieri.com> --- lib/atomic64.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/atomic64.c b/lib/atomic64.c index 8bee16e..a21c12b 100644 --- a/lib/atomic64.c +++ b/lib/atomic64.c @@ -162,12 +162,12 @@ int atomic64_add_unless(atomic64_t *v, long long a, long long u) { unsigned long flags; spinlock_t *lock = lock_addr(v); - int ret = 1; + int ret = 0; spin_lock_irqsave(lock, flags); if (v->counter != u) { v->counter += a; - ret = 0; + ret = 1; } spin_unlock_irqrestore(lock, flags); return ret; -- 1.6.6.1.476.g01ddb -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |