Prev: [PATCH 2/3] power/ds2760_battery: make charge_now and charge_full writeable
Next: [PATCH] vfs: fix RCU-lockdep false positive due to /proc access
From: Daniel Mack on 11 May 2010 12:50
In the ds2760 driver, the currently used factor of 10 to store the rated
battery capacity internally is not sufficient for batteries > 2.55 Ah,
as the 8-bit register will overflow for bigger values.

Change the factor to 20 to broaden that range. Note that due to
RATED_CAPACITY_FACTOR, the external interface won't change, neither for
the writeable sysfs entires nor for the kernel rated_capacity module
parameter.

Signed-off-by: Daniel Mack <daniel(a)caiaq.de>
Cc: Anton Vorontsov <avorontsov(a)ru.mvista.com>
Cc: Matt Reimer <mreimer(a)vpop.net>
Cc: Evgeniy Polyakov <zbr(a)ioremap.net>
Cc: Tejun Heo <tj(a)kernel.org>
Cc: David Woodhouse <dwmw2(a)infradead.org>
Cc: Len Brown <len.brown(a)intel.com>
Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com>
---
drivers/power/ds2760_battery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/power/ds2760_battery.c b/drivers/power/ds2760_battery.c
index b82bf92..7b3043f 100644
--- a/drivers/power/ds2760_battery.c
+++ b/drivers/power/ds2760_battery.c
@@ -78,7 +78,7 @@ MODULE_PARM_DESC(current_accum, "current accumulator value");

/* Some batteries have their rated capacity stored a N * 10 mAh, while
* others use an index into this table. */
-#define RATED_CAPACITY_FACTOR 10
+#define RATED_CAPACITY_FACTOR 20
static int rated_capacities[] = {
0,
920, /* Samsung */
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/3] power/ds2760_battery: make charge_now and charge_full writeable
Next: [PATCH] vfs: fix RCU-lockdep false positive due to /proc access