Prev: [PATCH 1/4] drivers/mtd/maps: introduce missing kfree
Next: [PATCHv3 1/2] virtio: support layout with avail ring before idx
From: Julia Lawall on 1 Jun 2010 10:40
From: Julia Lawall <julia(a)diku.dk>

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x(a)p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
....
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
....>
(
return \(0\|<+...x...+>\|ptr\);
|
return(a)p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>
---
drivers/scsi/arcmsr/arcmsr_hba.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index ffa5479..a94fb9d 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -1526,6 +1526,7 @@ static int arcmsr_iop_message_xfer(struct AdapterControlBlock *acb,
if (!acb->fw_state) {
pcmdmessagefld->cmdmessage.ReturnCode =
ARCMSR_MESSAGE_RETURNCODE_BUS_HANG_ON;
+ kfree(ver_addr);
goto message_out;
}

@@ -1578,6 +1579,7 @@ static int arcmsr_iop_message_xfer(struct AdapterControlBlock *acb,
if (!acb->fw_state) {
pcmdmessagefld->cmdmessage.ReturnCode =
ARCMSR_MESSAGE_RETURNCODE_BUS_HANG_ON;
+ kfree(ver_addr);
goto message_out;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/4] drivers/mtd/maps: introduce missing kfree
Next: [PATCHv3 1/2] virtio: support layout with avail ring before idx