Prev: [PATCH 2/7] vfs: inode_change_ok have to perform all necessery checks
Next: [PATCH 5/7] ext3: use nofail variant of inode_setattr()
From: Dmitry Monakhov on 19 Feb 2010 14:50
After quota was transfered, inode_setattr() may fail. This
is tricky situation because it may be impossible to
roll-back quota changes. But we have already done all
necessery changes in inode_change_ok() so it is safe to
use nofail version of inode_seattr() here.

Signed-off-by: Dmitry Monakhov <dmonakhov(a)openvz.org>
---
fs/attr.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/fs/attr.c b/fs/attr.c
index cc2a801..c1ae61c 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -243,7 +243,11 @@ int notify_change(struct dentry * dentry, struct iattr * attr)
error = vfs_dq_transfer(inode, attr) ?
-EDQUOT : 0;
if (!error)
- error = inode_setattr(inode, attr);
+ /*
+ * All necessery check already done, it is
+ * safe to use nofail version here.
+ */
+ __inode_setattr(inode, attr);
}
}

--
1.6.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/7] vfs: inode_change_ok have to perform all necessery checks
Next: [PATCH 5/7] ext3: use nofail variant of inode_setattr()