[PATCH 4/4] Checkpatch: warn about unexpectedly long msleep's
in [Kernel]
|
Prev: [PATCH] tracing: wake up tasks reading trace_pipe on write to trace_marker
Next: Btrfs: Add hot data tracking functionality
From: Patrick Pannuto on 27 Jul 2010 18:50 As explained in Documentation/timers/delays.txt, msleep's of < 20ms may sleep for as long as 20ms. Caller's of msleep(1) or msleep(2), etc are likely not to expect this quirky behavior - warn them. Signed-off-by: Patrick Pannuto <ppannuto(a)codeaurora.org> --- scripts/checkpatch.pl | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0650ab9..bbc2e76 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2583,6 +2583,13 @@ sub process { WARN("usleep_range is preferred over usleep; see Documentation/timers/delays.txt\n" . $line); } +# warn about unexpectedly long msleep's + if ($line =~ /\bmsleep\s*\((\d+)\);/) { + if ($1 < 20) { + WARN("msleep < 20ms can sleep for up to 20ms; see Documentation/timers/delays.txt\n" . $line); + } + } + # warn about #ifdefs in C files # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { # print "#ifdef in C files should be avoided\n"; -- 1.7.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |