Prev: [PATCH] MIPS: nofpu and nodsp only affect CPU0
Next: [PATCH 0/5] perf inject + say no to __KERNEL__ only stuff
From: Arnaldo Carvalho de Melo on 2 May 2010 19:00
From: Arnaldo Carvalho de Melo <acme(a)redhat.com>

With this I was able to actually test Tom Zanussi's two previous patches
in my usual perf testing ways, i.e. without any tracepoints activated.

Cc: Frédéric Weisbecker <fweisbec(a)gmail.com>
Cc: Mike Galbraith <efault(a)gmx.de>
Cc: Paul Mackerras <paulus(a)samba.org>
Cc: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
Cc: Tom Zanussi <tzanussi(a)gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme(a)redhat.com>
---
tools/perf/builtin-record.c | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index e382d93..ac989e9 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -666,12 +666,15 @@ static int __cmd_record(int argc, const char **argv)
nr_counters,
process_synthesized_event,
session);
- if (err <= 0) {
- pr_err("Couldn't record tracing data.\n");
- return err;
- }
-
- advance_output(err);
+ /*
+ * FIXME err <= 0 here actually means that there were no tracepoints
+ * so its not really an error, just that we don't need to synthesize
+ * anything.
+ * We really have to return this more properly and also propagate
+ * errors that now are calling die()
+ */
+ if (err > 0)
+ advance_output(err);
}

machine = perf_session__find_host_machine(session);
--
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] MIPS: nofpu and nodsp only affect CPU0
Next: [PATCH 0/5] perf inject + say no to __KERNEL__ only stuff