Prev: msi-laptop: Add threeg sysfs file for support query 3G state by standard 66/62 ec command
Next: [PATCH 62/62] sysfs: fix for thinko with sysfs_bin_attr_init()
From: Greg Kroah-Hartman on 2 Mar 2010 18:40
From: Eric W. Biederman <ebiederm(a)aristanetworks.com>

Placing the 16bit s_mode between a pointer and a long doesn't pack well
especailly on 64bit where we wast 48 bits. So move s_mode and
declare it as a unsigned short. This is the sysfs backing store
after all we don't need fields extra large just in case someday
we want userspace to be able to use a larger value.

Acked-by: Tejun Heo <tj(a)kernel.org>
Signed-off-by: Eric W. Biederman <ebiederm(a)aristanetworks.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>
---
fs/sysfs/sysfs.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
index 37e0e08..5a3192a 100644
--- a/fs/sysfs/sysfs.h
+++ b/fs/sysfs/sysfs.h
@@ -66,8 +66,8 @@ struct sysfs_dirent {
};

unsigned int s_flags;
+ unsigned short s_mode;
ino_t s_ino;
- umode_t s_mode;
struct sysfs_inode_attrs *s_iattr;
};

--
1.7.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: msi-laptop: Add threeg sysfs file for support query 3G state by standard 66/62 ec command
Next: [PATCH 62/62] sysfs: fix for thinko with sysfs_bin_attr_init()