[PATCH 6/6] Add comment in alloc_pages_exact_node
in [Kernel]
|
Prev: [PATCH 5/6] change alloc function in __vmalloc_area_node
Next: [PATCH 1/6] Remove node's validity check in alloc_pages
From: Minchan Kim on 13 Apr 2010 11:30 alloc_pages_exact_node naming makes some people misleading. They considered it following as. "This function will allocate pages from node which I wanted exactly". But it can allocate pages from fallback list if page allocator can't find free page from node user wanted. So let's comment this NOTE. Actually I wanted to change naming with better. ex) alloc_pages_explict_node. But I changed my mind since the comment would be enough. If anybody suggests better name, I will do with pleasure. Cc: Mel Gorman <mel(a)csn.ul.ie> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> Cc: Bob Liu <lliubbo(a)gmail.com> Signed-off-by: Minchan Kim <minchan.kim(a)gmail.com> --- include/linux/gfp.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/gfp.h b/include/linux/gfp.h index b65f003..7539c17 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -288,6 +288,11 @@ static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask, return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask)); } +/* + * NOTE : Allow page from fallback if page allocator can't find free page + * in your nid. Only if you want to allocate page from your nid, use + * __GFP_THISNODE flags with gfp_mask. + */ static inline struct page *alloc_pages_exact_node(int nid, gfp_t gfp_mask, unsigned int order) { -- 1.7.0.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |