Prev: [PATCH 5/6] call_usermodehelper: simplify/fix UMH_NO_WAIT case
Next: Staging: dream: generic_gpio: Use linux instead of asm uaccess.h
From: Oleg Nesterov on 15 Mar 2010 16:00
UMH_WAIT_EXEC should report the error if kernel_thread() fails, like
UMH_WAIT_PROC does.

Signed-off-by: Oleg Nesterov <oleg(a)redhat.com>
---

kernel/kmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- 34-rc1/kernel/kmod.c~6_UMH_WAIT_EXEC 2010-03-15 20:32:23.000000000 +0100
+++ 34-rc1/kernel/kmod.c 2010-03-15 20:37:07.000000000 +0100
@@ -235,10 +235,10 @@ static void __call_usermodehelper(struct
case UMH_WAIT_PROC:
if (pid > 0)
break;
- sub_info->retval = pid;
/* FALLTHROUGH */
-
case UMH_WAIT_EXEC:
+ if (pid < 0)
+ sub_info->retval = pid;
complete(sub_info->complete);
}
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 5/6] call_usermodehelper: simplify/fix UMH_NO_WAIT case
Next: Staging: dream: generic_gpio: Use linux instead of asm uaccess.h