[PATCH 6/7] vmscan: remove PF_SWAPWRITE from __zone_reclaim()
in [Kernel]
|
Prev: Documentation/padata.txt: fix typos etc.
Next: [PATCH 3/7] vmscan: synchrounous lumpy reclaim use lock_page() instead trylock_page()
From: KOSAKI Motohiro on 5 Aug 2010 02:20 When zone_reclaim() was merged at first, It always order-0 allocation with PF_SWAPWRITE flag. (probably they are both unintional). Former was fixed commit bd2f6199cf (vmscan: respect higher order in zone_reclaim()). However it expose latter mistake because !order-0 reclaim often cause dirty pages isolation and large latency. Now, we have good opportunity to fix latter too. Signed-off-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> --- mm/vmscan.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index f21dbeb..e043e97 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2663,7 +2663,7 @@ static int __zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order) * and we also need to be able to write out pages for RECLAIM_WRITE * and RECLAIM_SWAP. */ - p->flags |= PF_MEMALLOC | PF_SWAPWRITE; + p->flags |= PF_MEMALLOC; lockdep_set_current_reclaim_state(gfp_mask); reclaim_state.reclaimed_slab = 0; p->reclaim_state = &reclaim_state; @@ -2716,7 +2716,7 @@ static int __zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order) } p->reclaim_state = NULL; - current->flags &= ~(PF_MEMALLOC | PF_SWAPWRITE); + current->flags &= ~PF_MEMALLOC; lockdep_clear_current_reclaim_state(); return sc.nr_reclaimed >= nr_pages; } -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |