Prev: [PATCH 3/9] kgdboc: Add call backs to allow kernel mode switching
Next: [PATCH 01/17] kgdb: remove custom hex_to_bin()implementation
From: Jason Wessel on 5 Aug 2010 10:50
Commit 5349ef3127c77075ff70b2014f17ae0fbcaaf199 (drm/fb: fix
FBIOGET/PUT_VSCREENINFO pixel clock handling) changed the logic of
when a pixclock was valid vs invalid.

The atomic kernel mode setting used by the kernel debugger relies upon
the drm_fb_helper_check_var() to always return -EINVAL. Until a
better solution exists, this behavior will be restored.

CC: David Airlie <airlied(a)linux.ie>
CC: Jesse Barnes <jbarnes(a)virtuousgeek.org>
CC: Clemens Ladisch <clemens(a)ladisch.de>
Signed-off-by: Jason Wessel <jason.wessel(a)windriver.com>
---
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 6245add..de82e20 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -685,7 +685,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
struct drm_framebuffer *fb = fb_helper->fb;
int depth;

- if (var->pixclock != 0)
+ if (var->pixclock != 0 || in_dbg_master())
return -EINVAL;

/* Need to resize the fb object !!! */
--
1.6.4.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 3/9] kgdboc: Add call backs to allow kernel mode switching
Next: [PATCH 01/17] kgdb: remove custom hex_to_bin()implementation