Prev: mfd: off by one calculating size
Next: [PATCH] Fix key f70f4b50 not in .data in thermal_sys
From: David Howells on 22 Mar 2010 09:10
From: Dan Carpenter <error27(a)gmail.com>

It seems clear from the surrounding code that xpermits is allowed to be NULL
here.

Signed-off-by: Dan Carpenter <error27(a)gmail.com>
Signed-off-by: David Howells <dhowells(a)redhat.com>
---

fs/afs/security.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/afs/security.c b/fs/afs/security.c
index 3ef5043..bb4ed14 100644
--- a/fs/afs/security.c
+++ b/fs/afs/security.c
@@ -189,8 +189,9 @@ void afs_cache_permit(struct afs_vnode *vnode, struct key *key, long acl_order)
if (!permits)
goto out_unlock;

- memcpy(permits->permits, xpermits->permits,
- count * sizeof(struct afs_permit));
+ if (xpermits)
+ memcpy(permits->permits, xpermits->permits,
+ count * sizeof(struct afs_permit));

_debug("key %x access %x",
key_serial(key), vnode->status.caller_access);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: mfd: off by one calculating size
Next: [PATCH] Fix key f70f4b50 not in .data in thermal_sys