[PATCH] Fix staging:iio:ring_sw: Fix incorrect test on successful read of last value, causes infinite loop
in [Kernel]
|
Prev: [PATCH] oom: fix the unsafe proc_oom_score()->badness() call
Next: ath: fix code readability in regd.c
From: Jonathan Cameron on 30 Mar 2010 12:50 Signed-off-by: Jonathan Cameron <jic23(a)cam.ac.uk> --- This is a bad one. The test means that almost no reads of the last value ever succeed! Result is an infinite loop. Another one for the 'oops' category. Patch is post the spin lock fix: [PATCH] Staging: IIO: Fix uses of spinlocks prior to init in ring implementations drivers/staging/iio/ring_sw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/ring_sw.c b/drivers/staging/iio/ring_sw.c index 7dff2bf..5abba8c 100644 --- a/drivers/staging/iio/ring_sw.c +++ b/drivers/staging/iio/ring_sw.c @@ -296,7 +296,7 @@ again: return -EAGAIN; memcpy(data, last_written_p_copy, ring->buf.bpd); - if (unlikely(ring->last_written_p >= last_written_p_copy)) + if (unlikely(ring->last_written_p != last_written_p_copy)) goto again; iio_unmark_sw_rb_in_use(&ring->buf); -- 1.6.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |