Prev: mapping object names to role IDs
Next: [HACKERS] Exposing the Xact commit order to the user
From: Michael Meskes on 24 May 2010 15:11
> I think the current coding is extremely fragile (if it indeed works at
> all) because of its assumption that <limits.h> has been included

Well, this is the case in the code so far.

> already. In any case, we have configure tests that exist only for the
> benefit of contrib modules, so it's hard to argue that we shouldn't have
> one that exists only for ecpg.
>
> I think we should fix this (properly) for 9.0.

Ok, I don't mind fixing it properly for 9.0. Will do so as soon as I find time.

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes(a)jabber.org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Stephen Frost on 24 May 2010 15:20
* Michael Meskes (meskes(a)postgresql.org) wrote:
> > I think the current coding is extremely fragile (if it indeed works at
> > all) because of its assumption that <limits.h> has been included
>
> Well, this is the case in the code so far.

Right, the existing code is after limits.h is included, my suggestion to
put it in c.h would have lost limits.h and broken things. Sorry about
that. I didn't realize the dependency and make check didn't complain
(not that I'm sure there's even a way we could have a regression test
for this..). I didn't intend to imply the currently-committed code
didn't work (I figured it was probably fine :), was just trying to tidy
a bit.

Thanks!

Stephen
First  |  Prev  | 
Pages: 1 2
Prev: mapping object names to role IDs
Next: [HACKERS] Exposing the Xact commit order to the user