Prev: [PATCH 2/2] AIO: Change pr_debug statements to dprintk in fs/aio.c
Next: [PATCH] drivers/net/wimax/i2400m/fw.c fix possible double free
From: David Howells on 16 Mar 2010 07:50
Fix an incorrect comment in the do_mmap_shared_file(). If a mapping is
requested MAP_SHARED, then a private copy cannot be made and still provide
correct semantics.

Reported-by: Dave Hudson <uclinux(a)blueteddy.net>
Signed-off-by: David Howells <dhowells(a)redhat.com>
---

mm/nommu.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)


diff --git a/mm/nommu.c b/mm/nommu.c
index 605ace8..e4b8f4d 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1040,10 +1040,9 @@ static int do_mmap_shared_file(struct vm_area_struct *vma)
if (ret != -ENOSYS)
return ret;

- /* getting an ENOSYS error indicates that direct mmap isn't
- * possible (as opposed to tried but failed) so we'll fall
- * through to making a private copy of the data and mapping
- * that if we can */
+ /* getting -ENOSYS indicates that direct mmap isn't possible (as
+ * opposed to tried but failed) so we can only give a suitable error as
+ * it's not possible to make a private copy if MAP_SHARED was given */
return -ENODEV;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/2] AIO: Change pr_debug statements to dprintk in fs/aio.c
Next: [PATCH] drivers/net/wimax/i2400m/fw.c fix possible double free