From: Tom Lane on
Priit Laes <plaes(a)plaes.org> writes:
> This patch enables showing configure status at the end of ./configure
> run and thus makes ./configure process a bit easier to follow (in the
> sense of what features are actually enabled).

I don't think anybody actually reads configure's output anyway, so I'm
not sure about the point of this. Usually you wish you knew this
information long afterwards. We do have tools (pg_config,
pg_controldata) for extracting such information from an existing
installation, which is the real use-case IMHO.

Also, it's quite unclear which items deserve a place in the list.
If it's just to repeat what was in the configure command-line, what
is the value of that?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Wed, Feb 10, 2010 at 12:01 PM, Priit Laes <plaes(a)plaes.org> wrote:
>> Also, it's quite unclear which items deserve a place in the list.
>> If it's just to repeat what was in the configure command-line, what
>> is the value of that?
>
> It might avoid the 'FFFFUUUUUU, I forgot to enable python support.',
> after you have waited a while for the build to finish...

Hmm. That implies that you didn't look at the command that you typed
but you did look at its output. I'm not going to say "no one does
that" (who am I to judge?) but it seems kind of strange to me.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Wed, Feb 10, 2010 at 2:16 PM, Alvaro Herrera
<alvherre(a)commandprompt.com> wrote:
> Maybe you didn't type it, but it came from elsewhere?  Maybe you're
> inheriting settings from some environment variable, or a file?  Maybe
> you're eval'ing pg_config --configure?

Yeah, could be.

> The general idea seems sensible to me.  I can't comment on the
> specifics.

I took a quick look at it. It's basically just a block of output at
the end of configure that reflects the values for a subset of the
configuration parameters (for example, just off the top of my head,
--enable-debug, --enable-casserts, --enable-depend, and --enable-nls
aren't there). It already won't fit in a 24x80 window, and if we
actually make it complete, it'll be considerably longer. While not
denying its possible usefulness to the OP, I'm not sure that in
general more people would find it useful than annoying. I might be
wrong, though.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Wed, Feb 10, 2010 at 3:30 PM, Alvaro Herrera
<alvherre(a)commandprompt.com> wrote:
> Euler Taveira de Oliveira escribió:
>> Alvaro Herrera escreveu:
>> > The general idea seems sensible to me.  I can't comment on the
>> > specifics.
>> >
>> +1. A lot of other programs have this summary at the end of configure
>> execution. The problem is that PostgreSQL has too many options. Do we want to
>> list all of them?
>
> Maybe not all, but my bike is colored PGPORT, and this shed doesn't seem
> to have anything that combines with that.

Well said, sir.

> If this doesn't fit in 24x80 maybe we need to find a more compact way to
> display things.

+1. I wouldn't mind a one-line summary, but a two page summary seems
like a lot.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on
Robert Haas <robertmhaas(a)gmail.com> writes:
> On Wed, Feb 10, 2010 at 3:30 PM, Alvaro Herrera
> <alvherre(a)commandprompt.com> wrote:
>> If this doesn't fit in 24x80 maybe we need to find a more compact way to
>> display things.

> +1. I wouldn't mind a one-line summary, but a two page summary seems
> like a lot.

So it seems there's some consensus that:

1. This printout should display everything configurable from a configure
option, and nothing else (ie, not any of the platform-dependent
conclusions that configure draws).

2. The printout has to be made to fit in 24x80 or so.

I'm still quite dubious about the usefulness, but I could live with this
if someone explains to me how the printout is going to stay within 24x80
given the inevitable growth in number of configure options ...

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers