[PATCH] Revert "writeback: limit write_cache_pages integrity scanning to current EOF"
in [Kernel]
|
Prev: sparc: break out some prom device-tree building code out into drivers/of
Next: [PATCH UPDATED 12/35] workqueue: update cwq alignement
From: Joel Becker on 29 Jun 2010 04:20 On Mon, Jun 28, 2010 at 07:20:33PM -0700, Linus Torvalds wrote: > I dunno. Filesystem corruption makes me nervous. So I'm certainly > totally willing to do the revert if that makes ocfs2 work again. Even > if "work again" happens to be partly by mistake, and for some reason > that isn't obvious. Filesystem corruption makes me more than nervous. I'm quite devastated by this. > Your call, I guess. If any ocfs2 fix looks scary, and you'd prefer to > have an -rc4 (in a few days - not today) with just the revert, I'm ok > with that. Even if it's only a "at least no worse than 2.6.34" > situation rather than a real fix. I've checked both before this patch and with the patch reverted. We corrupt in both cases. The problem is our assumption about zeroing past i_size. The revert will fix our BUG_ON, but not the corruption. Mark and I have ideas on how to fix the actual bug, but they will take some time and especially testing. We also have some shorter-term ideas on how to paper over the issue. We have to have to have this fixed by .35. If -rc4 isn't coming for a couple of days, can we hold off on the decision until we get a chance to think about a paper-over solution for it? Then we can avoid the revert. Joel -- You can use a screwdriver to screw in screws or to clean your ears, however, the latter needs real skill, determination and a lack of fear of injuring yourself. It is much the same with JavaScript. - Chris Heilmann Joel Becker Consulting Software Developer Oracle E-mail: joel.becker(a)oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joel Becker on 29 Jun 2010 21:40 On Tue, Jun 29, 2010 at 01:16:11AM -0700, Joel Becker wrote: > On Mon, Jun 28, 2010 at 07:20:33PM -0700, Linus Torvalds wrote: > > Your call, I guess. If any ocfs2 fix looks scary, and you'd prefer to > > have an -rc4 (in a few days - not today) with just the revert, I'm ok > > with that. Even if it's only a "at least no worse than 2.6.34" > > situation rather than a real fix. > > If -rc4 isn't coming for a couple of days, can we hold off on > the decision until we get a chance to think about a paper-over solution > for it? Then we can avoid the revert. Linus, I'm going to withdraw the revert request for now. Our proposed paper-over solution is too big, and we're just going to focus on the actual fix. This will be for .35. Yes, .35-rc will have a BUG_ON with refcount trees until we get the fix in, but I'd rather avoid the churn when the final .35 should have Dave's patch and our fix. Joel -- "The first thing we do, let's kill all the lawyers." -Henry VI, IV:ii Joel Becker Consulting Software Developer Oracle E-mail: joel.becker(a)oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joel Becker on 6 Jul 2010 15:10
On Mon, Jun 28, 2010 at 06:58:23PM -0700, Joel Becker wrote: > Oh, no, that's not it at all. This is a disaster. I can't see > for the life of me why we haven't had 100,000 bug reports. You're going Btw, we've figured out why we don't have 100,000 bug reports. Most normal usage will never encounter this. But it is still a serious problem, and the fix is just as high a priority. Joel P.S.: Thanks, LWN, for making me look good on the QotW ;-) -- "I inject pure kryptonite into my brain. It improves my kung fu, and it eases the pain." Joel Becker Consulting Software Developer Oracle E-mail: joel.becker(a)oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |