PATCH] Scripts: checkpatch: change externals to globals
in [Kernel]
|
Prev: Linux 2.6.35-rc4 - CONFIG_LOCALVERSION ignored?
Next: [PATCH 2/2] Staging: dt3155: fix coding style issues in dt3155_drv.c
From: Joe Eloff on 5 Jul 2010 17:40 >From 9745542c84ef223eec8309a9fb7abf225153419d Mon Sep 17 00:00:00 2001 From: Joe Eloff <kagen101(a)gmail.com> Date: Mon, 5 Jul 2010 23:28:21 +0200 Subject: [PATCH] Scripts: checkpatch: change externals to globals Made error message say 'ERROR: do not initialise globals to 0 or NULL' rather than 'ERROR: do not initialise externals to 0 or NULL'. Makes more sense in the context since there is an extern keyword in C and that is a global declaration within the scope of the current file. Signed-off-by: Joe Eloff <kagen101(a)gmail.com> --- scripts/checkpatch.pl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bd88f11..6b003cf 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1778,9 +1778,9 @@ sub process { WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr); } -# check for external initialisers. +# check for global initialisers. if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) { - ERROR("do not initialise externals to 0 or NULL\n" . + ERROR("do not initialise globals to 0 or NULL\n" . $herecurr); } # check for static initialisers. -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |